Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router-outlet): getRouteId() method now returns parameters #24656

Merged
merged 1 commit into from
Feb 9, 2022
Merged

fix(router-outlet): getRouteId() method now returns parameters #24656

merged 1 commit into from
Feb 9, 2022

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 26, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

getRouteId() does not set the params

Issue Number: fixes #24652

What is the new behavior?

getRouteId() sets the params

Does this introduce a breaking change?

  • Yes
  • No

@vicb vicb requested a review from a team as a code owner January 26, 2022 02:08
@github-actions github-actions bot added the package: core @ionic/core package label Jan 26, 2022
@vicb vicb changed the title Router outlet 1 fix(router-outlet): getRouteId() returns the params set in setRouteId(). Jan 26, 2022
sean-perkins
sean-perkins approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code modifications look good, great work. My comment is non-blocking and more of a discussion point that other members of the team can add to, if they feel it needs a change.

@sean-perkins sean-perkins requested a review from a team February 9, 2022 04:24
@sean-perkins sean-perkins requested a review from a team February 9, 2022 04:29
@liamdebeasi liamdebeasi changed the title fix(router-outlet): getRouteId() returns the params set in setRouteId(). fix(router-outlet): getRouteId() method now returns parameters Feb 9, 2022
@liamdebeasi liamdebeasi merged commit be2205e into ionic-team:main Feb 9, 2022
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

@liamdebeasi liamdebeasi mentioned this pull request Feb 9, 2022
Closed
6 tasks
This was referenced Mar 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averyjohnston averyjohnston averyjohnston approved these changes

@sean-perkins sean-perkins sean-perkins approved these changes

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: router-outlet getRouteId() should returns the params
4 participants
@vicb @liamdebeasi @sean-perkins @averyjohnston