fix(datetime): navigate to month within min range #24759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When providing a
min
value toion-datetime
that includes a day, the month of themin
value will be disabled and once you have navigated away from it, you will be unable to return to it.This is because the
isBefore
/isAfter
checks additionally compare the day value, when min/max includes it. This is correct for date comparisons, but isn't a 1:1 with rules surrounding disabling months.Issue Number: #24757
What is the new behavior?
Users can navigate to min/max months, when the
min
/max
value includes a day constraint.i.e.: If the
min
is2022-02-09
, users should still be able to navigate to February, since days 10-28 are enabled.Does this introduce a breaking change?
Other information