fix(toast): toast is now correctly excluded from focus trapping #24816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #24733
There are a few issues here:
Opening an overlay adds a global
focus
event listener that activates focus trapping. However, we had special logic to prevent toast from adding that global listener. The problem is that this listener is added once globally, so if you open a focus trapping overlay before you open toast, you can defeat this special logic.The focus trapping utility doesn't actually exclude ion-toast like it says it should.
The
ion-menu
check inoverlays.ts
was redundant because focus trapping there only ever runs on overlay components.What is the new behavior?
OverlayListenerOptions
options as it was easily defeated given the scenario above.ion-menu
specific check. There are tests inmenu/test/focus-trap
that verify that menu focus trapping with overlays still works.Does this introduce a breaking change?
Other information