Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial goto impl for signature file #1111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheAngryByrd
Copy link
Member

@TheAngryByrd TheAngryByrd commented May 9, 2023

WHAT

🤖 Generated by Copilot at cf01557

This pull request improves the support for signature files in FsAutoComplete by adding helper functions to convert file names and filtering out irrelevant symbols from code completion and tooltips. It affects the ProcessHelper and Commands modules in the src/FsAutoComplete.Core folder.

🤖 Generated by Copilot at cf01557

To support signature files in F#
We filter symbols with some zest
We use filterSymbols and ProcessHelper
To match the files with .fsi and .fs
And avoid showing duplicates or incorrect stuff

📝🔎🛠️

WHY

HOW

🤖 Generated by Copilot at cf01557

  • Add support for signature files in code completion and tooltips by filtering out irrelevant symbols (link, link, link)
  • In src/FsAutoComplete.Core/Commands.fs, modify filterSymbols to check if the file is a signature file (.fsi) and only keep the symbols that match the implementation file (.fs) (link)
  • In src/FsAutoComplete.Core/Utils.fs, add helper functions toSignatureFile and toFSharpFile to convert file names between signature and implementation files (link, link)

@TheAngryByrd TheAngryByrd force-pushed the goto-implementation-signature branch from cf01557 to ea9a1db Compare July 9, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant