Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust biz logic. #199

Merged
merged 47 commits into from
Nov 5, 2021
Merged

Adjust biz logic. #199

merged 47 commits into from
Nov 5, 2021

Conversation

cloudwebrtc
Copy link
Contributor

@cloudwebrtc cloudwebrtc commented May 9, 2021 •
edited by adwpc
Loading

Description

  • redesign protocol
  • Add token and metadata.
  • Throw an error when the upstream server crashes abnormally.

@cloudwebrtc cloudwebrtc changed the title Add token and metadata. [WIP] Adjust biz logic. May 9, 2021
@cloudwebrtc cloudwebrtc force-pushed the adjust-biz-logic branch 2 times, most recently from 299496a to f2e0fe7 Compare May 11, 2021 14:29
@adwpc adwpc self-requested a review November 3, 2021 07:01
@adwpc adwpc changed the title [WIP] Adjust biz logic. Adjust biz logic. Nov 3, 2021
@adwpc adwpc requested a review from billylindeman November 3, 2021 08:55
adwpc
adwpc approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@adwpc adwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwpc adwpc merged commit 6ecd657 into master Nov 5, 2021
@adwpc adwpc deleted the adjust-biz-logic branch November 5, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwpc adwpc adwpc approved these changes

@billylindeman billylindeman Awaiting requested review from billylindeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @adwpc