SFU: Register the ssrc-audio-level RTP extension #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2021
All major browser negotiate this. Adding it to ion-sfu means it will get passed on to ion-avp, which can then do active speaker detection. I noticed TransportCCURI was video only, and this one is audio only, so I split the registration into two loops. Updates pion/sdp dependency to 3.0.4
grahamking
force-pushed
the
register-audio-level-ext
branch
from
1a8963a to
15d6ebc
Compare
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 42.77% 42.95% +0.18%
==========================================
Files 19 19
Lines 1730 1732 +2
==========================================
+ Hits 740 744 +4
+ Misses 894 893 -1
+ Partials 96 95 -1
Continue to review full report at Codecov.
|
OrlandoCo
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All major browser negotiate this. Adding it to ion-sfu means it will
get passed on to ion-avp, which can then do active speaker detection.
I noticed TransportCCURI was video only, and this one is audio only, so
I split the registration into two loops.
Depends on pion/sdp#94