-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NoAutoSubscribe to peer.JoinConfig. #558
Conversation
This event is used to monitor the publisher OnTrack event and distribute the event to other members in the session through signaling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. seems no break changes
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 40.24% 39.80% -0.45%
==========================================
Files 23 23
Lines 2430 2437 +7
==========================================
- Hits 978 970 -8
- Misses 1324 1336 +12
- Partials 128 131 +3
Continue to review full report at Codecov.
|
266a58e
to
c92f06a
Compare
@OrlandoCo updated |
Description
Do not subscribe to any stream during peer join, so that the application layer can perform fine control and subscribe on-demand
1, Listen publisher.OnPublishTrack event, generate StreamEvent and broadcast to each peer.
2,Peer uses the trackIds in StreamEvent to subscribe or unsubscribe.