Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mobile rename profile #2512

Merged
merged 14 commits into from
May 13, 2022
Merged

feat: mobile rename profile #2512

merged 14 commits into from
May 13, 2022

Conversation

amadeu2
Copy link
Contributor

@amadeu2 amadeu2 commented Mar 8, 2022 •
edited
Loading

Summary

The main menu has an option to rename Profile where the folder is renamed. Will use the Capacitor plugin SecureFilesystemAccess for that feature.

Changelog

-[x] Implement renameProfileFolder on CapacitorApi.ts
-[x] Verify the folder was renamed on device filesystem

Relevant Issues

Closes #2511

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@amadeu2 amadeu2 self-assigned this Mar 8, 2022
@amadeu2 amadeu2 added platform:mobile type:feature Adding a new feature or functionality labels Mar 8, 2022
@amadeu2 amadeu2 added this to the Mobile 1.0.0-alpha milestone Mar 8, 2022
amadeu2 added 4 commits March 8, 2022 21:23
@amadeu2
fix bindings definitions
6d09963 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
add plugin code to use profilePath var
ddf725f 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
fix bindings API to use storagePath
ccfd2a9 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
implement plugin Java code
b1dc39b 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 marked this pull request as ready for review March 9, 2022 18:08
@amadeu2 amadeu2 requested a review from cvarley100 as a code owner March 9, 2022 18:08
@amadeu2
fix format
c5ceeb6 
Signed-off-by: Amadeo Marchioni <[email protected]>
amadeu2 added 2 commits March 9, 2022 18:48
@amadeu2
ensure received vars are not null on Java code
7b36fe4 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
more fixes on Java code
e0d102c 
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 mentioned this pull request Mar 13, 2022
Closed
3 tasks
@maxwellmattryan maxwellmattryan changed the title Feat: Mobile rename profile feat: mobile rename profile Mar 16, 2022
amadeu2
amadeu2 commented May 12, 2022
View reviewed changes
Copy link
Contributor Author

@amadeu2 amadeu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked again, seems ready 🙂

@amadeu2 amadeu2 requested a review from rajivshah3 May 12, 2022 02:52
@amadeu2 amadeu2 merged commit 21942ec into develop May 13, 2022
@amadeu2 amadeu2 deleted the feat/mobile-rename-profile branch May 13, 2022 12:35
amadeu2 added a commit that referenced this pull request May 17, 2022
@amadeu2
Merge branch 'develop' into fix/capacitor-wallet-plugin
35e8b9a 
* develop:
  New Crowdin translations by Github Action (#3220)
  New Crowdin translations by Github Action (#2964)
  feat: mobile rename profile (#2512)
  chore: sync strings from Desktop 1.5.2 to develop (#3184)
  fix: receive qr responsiveness (#3159)

Signed-off-by: Amadeo Marchioni <[email protected]>
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivshah3 rajivshah3 rajivshah3 approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@amadeu2 amadeu2

Labels
type:feature Adding a new feature or functionality
Projects
None yet
Milestone
E08.M1 - Mobile 1.0.0-alpha
Development

Successfully merging this pull request may close these issues.

[Task]: Rename account on mobile
2 participants
@amadeu2 @rajivshah3