Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: strip Linux backend debug info and upload to Sentry #3188

Merged
merged 1 commit into from
May 19, 2022

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented May 12, 2022

Summary

It turns out that even though we include the debug info in the Linux backend bindings that we ship with Firefly, Sentry does not symbolicate errors from them (in the firefly-desktop package) without receiving the debug info through a CLI upload. Therefore, we can upload the debug info to Sentry during the CI build and then strip it from the bindings that will be included in a build in Firefly. This reduces the size of the bindings from approximately 701 MB to approximately 37 MB.

Changelog

- Strip debug info from Linux Node.js bindings during CI build
- Upload debug info to Sentry

Relevant Issues

Fixes #2568

Type of Change

  • Chore - refactoring, build scripts or anything else that isn't user-facing

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Triggered crashes to check if Sentry recognized the corresponding debug file. Also tested upload with GHA

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have verified that my latest changes pass CI workflows for testing and linting

@cvarley100
Copy link
Contributor

cvarley100 commented May 13, 2022

701 MB to approximately 37 MB

ayy lmao

@rajivshah3 rajivshah3 marked this pull request as ready for review May 16, 2022 21:16
@rajivshah3 rajivshah3 requested a review from cvarley100 May 17, 2022 01:57
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound 👍

@rajivshah3 rajivshah3 merged commit 2f8a723 into develop May 19, 2022
@rajivshah3 rajivshah3 deleted the chore/linux-debug-info branch May 19, 2022 18:48
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Affects CI actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Reduce Node.js bindings size on Linux when built with debug info
3 participants