Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt settings for mobile (UI) 2 #3249

Merged
merged 15 commits into from
May 19, 2022
Merged

Conversation

amadeu2
Copy link
Contributor

@amadeu2 amadeu2 commented May 18, 2022

Summary

This PR replace #2271, it's a cleaner version of #2590.

Changelog

Adapt Profile menu with all UI settings to mobile.

Relevant Issues

Closes #2064
Closes #2063
Closes #2062
Closes #2061
Closes #2060
Closes #2259
Closes #2095

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

amadeu2 added 8 commits May 17, 2022 21:21
* feat/settings-mobile_new:
  chore: restore profileColor variable
  chore: fix lint error on Sidebar.svelte
  chore: restore Sidebar export
  chore: fix format lint
  chore: restore Sidebar.svelte, remove mobile code
  fix: adjust main menu styling
  fix: add safe area view spacing to settings
  chore: remove sidebar component
  chore: adapt Login comp to mobile
  feat: add Switch Accounts button to setttings menu
  chore: remove duplicated code on Settings comp
  chore: add MainMenu and remove Sidebar from Dashboard
  chore: remove icons from menu as Figma design
  feat: add MainMenu only mobile component
  chore: add zIndex prop to Drawer comp
  fix: add prop `opened` on settings Drawer
  fix: recover import
  fix mobile settings help links
  fix css class typo
  adapt settings to mobile

Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 added type:feature Adding a new feature or functionality platform:mobile labels May 18, 2022
@amadeu2 amadeu2 added this to the E08.M1 - Mobile 1.0.0-alpha milestone May 18, 2022
@amadeu2 amadeu2 requested a review from paul-boegelsack May 18, 2022 00:36
@amadeu2 amadeu2 requested a review from cvarley100 as a code owner May 18, 2022 00:36
@amadeu2 amadeu2 self-assigned this May 18, 2022
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Amadeo, I have a few little things. Unfortunately I can't test the desktop package with that branch. Do you think desktop still runs fine?

packages/shared/components/MainMenu.svelte Outdated Show resolved Hide resolved
packages/shared/components/Sidebar.svelte Outdated Show resolved Hide resolved
packages/shared/components/Sidebar.svelte Show resolved Hide resolved
packages/shared/components/index.js Outdated Show resolved Hide resolved
packages/shared/components/index.js Outdated Show resolved Hide resolved
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2
Copy link
Contributor Author

amadeu2 commented May 19, 2022

Hey Amadeo, I have a few little things. Unfortunately I can't test the desktop package with that branch. Do you think desktop still runs fine?

To get desktop working I had to add the parameter --no-sandbox next to the electron command inside the packages/desktop/package.json file, ex:

"scripts": {
    ...
    "start:electron": "cross-env NODE_ENV=development PLATFORM=desktop electron --no-sandbox public/build/main.js",
    "start:electron-prod": "cross-env NODE_ENV=production PLATFORM=desktop electron --no-sandbox public/build/main.js",
    ....
}

seems to be related to a temporal Electron issue with Chromium webview.

amadeu2 added 4 commits May 18, 2022 21:45
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 requested a review from paul-boegelsack May 19, 2022 01:14
amadeu2 added 2 commits May 19, 2022 11:18
Signed-off-by: Amadeo Marchioni <[email protected]>
@amadeu2 amadeu2 merged commit c9f3aef into develop May 19, 2022
@amadeu2 amadeu2 deleted the feat/settings-mobile_new_2 branch May 19, 2022 18:26
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment