-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt settings for mobile (UI) 2 #3249
Conversation
* feat/settings-mobile_new: chore: restore profileColor variable chore: fix lint error on Sidebar.svelte chore: restore Sidebar export chore: fix format lint chore: restore Sidebar.svelte, remove mobile code fix: adjust main menu styling fix: add safe area view spacing to settings chore: remove sidebar component chore: adapt Login comp to mobile feat: add Switch Accounts button to setttings menu chore: remove duplicated code on Settings comp chore: add MainMenu and remove Sidebar from Dashboard chore: remove icons from menu as Figma design feat: add MainMenu only mobile component chore: add zIndex prop to Drawer comp fix: add prop `opened` on settings Drawer fix: recover import fix mobile settings help links fix css class typo adapt settings to mobile Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Amadeo, I have a few little things. Unfortunately I can't test the desktop package with that branch. Do you think desktop still runs fine?
packages/shared/routes/dashboard/settings/views/advanced/NetworkConfiguration.svelte
Show resolved
Hide resolved
packages/shared/routes/dashboard/settings/views/advanced/Advanced.svelte
Outdated
Show resolved
Hide resolved
packages/shared/routes/dashboard/settings/views/general/General.svelte
Outdated
Show resolved
Hide resolved
packages/shared/routes/dashboard/settings/views/security/Security.svelte
Outdated
Show resolved
Hide resolved
Signed-off-by: Amadeo Marchioni <[email protected]>
To get desktop working I had to add the parameter "scripts": {
...
"start:electron": "cross-env NODE_ENV=development PLATFORM=desktop electron --no-sandbox public/build/main.js",
"start:electron-prod": "cross-env NODE_ENV=production PLATFORM=desktop electron --no-sandbox public/build/main.js",
....
} seems to be related to a temporal Electron issue with Chromium webview. |
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Signed-off-by: Amadeo Marchioni <[email protected]>
Summary
This PR replace #2271, it's a cleaner version of #2590.
Changelog
Relevant Issues
Closes #2064
Closes #2063
Closes #2062
Closes #2061
Closes #2060
Closes #2259
Closes #2095
Type of Change
Please select any type below that is applicable to your changes, and delete those that are not.
Testing
Platforms
Please select any platforms where your changes have been tested.
Instructions
Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.
Checklist
Please tick all of the following boxes that are relevant to your changes, and delete those that are not.