Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Launch screen on Android is not keeping aspect ratio #3257

Conversation

paul-boegelsack
Copy link
Contributor

@paul-boegelsack paul-boegelsack commented May 19, 2022

Summary

Changed the process of generating splash screen files for Android. The assetgen script now generates nine patch files:
https://www.joshmorony.com/creating-a-dynamic-universal-splash-screen-for-capacitor-android/#what-is-a-9-patch-file

Changelog

- Modified assetgen.sh to create splash.9.png files for better splash screen scaling
- Updated .gitignore
- Added launch_splash.xml to use nine patch files

Relevant Issues

Closes #3098

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack requested a review from amadeu2 May 19, 2022 10:50
@paul-boegelsack paul-boegelsack self-assigned this May 19, 2022
@paul-boegelsack paul-boegelsack linked an issue May 19, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@amadeu2 amadeu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aspect ratio works perfect on different sicreen sizes, and now looks better as the logo size is homogeneous with the iOS slplash screen. Good work! 💪

@paul-boegelsack paul-boegelsack merged commit 2b06a7e into develop May 19, 2022
@paul-boegelsack paul-boegelsack deleted the chore/launch-screen-on-android-is-not-keeping-aspect-ratio branch May 19, 2022 18:59
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Launch screen on Android is not keeping aspect ratio
2 participants