Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable firefly changed popup on setup #3299

Merged
merged 1 commit into from
May 23, 2022

Conversation

cvarley100
Copy link
Contributor

Summary

Disables "Firefly has changed" popup if the user is creating a new profile, or recovering an existing one.

Changelog

- Updates profile builder to set hasFinishedSingleAccountGuide to true

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cvarley100 cvarley100 force-pushed the fix/disable-firefly-changed-popup-on-setup branch from 5093333 to 13af239 Compare May 23, 2022 16:40
@cvarley100 cvarley100 changed the title Fix/disable firefly changed popup on setup fix: disable firefly changed popup on setup May 23, 2022
@cvarley100 cvarley100 changed the base branch from develop to release/desktop-1.6.0 May 23, 2022 16:41
@cvarley100 cvarley100 changed the base branch from release/desktop-1.6.0 to develop May 23, 2022 16:43
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cvarley100 cvarley100 merged commit 932920a into develop May 23, 2022
@cvarley100 cvarley100 deleted the fix/disable-firefly-changed-popup-on-setup branch May 23, 2022 17:00
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants