Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge tag desktop-1.6.5 into develop #4189

Merged
merged 218 commits into from
Aug 11, 2022
Merged

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Aug 9, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

Notes:

Had to move haveStakingResultsCached to packages/shared/lib/wallet.ts because it was giving me circular dependency when it was defined in packages/shared/lib/participation/participation.ts

Changelog

- chore: merge tag desktop-1.6.5 into develop

Relevant Issues

Please list any related issues using development keywords.

Closes #3951

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

begonaalvarezd and others added 30 commits February 17, 2022 17:30
chore: Move `selectedAccount` to global state
fix: ledger regenerate address
* chore: move viewableAccounts & liveAccounts to Dashboard.svelte to expose globally

* feat: add top navigation with switcher modal

* feat: improve css

* feat: add max height to account switcher

* fix: account switcher css

* feat: rename AccountNavigation component to TopNavigation

* feat: add missing top nav border

* fix: restore DeveloperProfileIndicator

* fix: css typo

* fix: remove commented code

* fix: remove unused locale

* fix: dashboard flex height

* fix: typing
* chore: move viewableAccounts & liveAccounts to Dashboard.svelte to expose globally

* feat: add top navigation with switcher modal

* feat: improve css

* feat: add max height to account switcher

* fix: account switcher css

* feat: rename AccountNavigation component to TopNavigation

* feat: add missing top nav border

* fix: restore DeveloperProfileIndicator

* fix: css typo

* feat: add sidebar tab component with tooltips

* fix: remove commented code

* fix: remove unused locale

* fix: dashboard flex height

* fix: typing

* fix: typing
* feat: adds stronghold status and action to profile modal

* fix: polishes layout

* fix: adds isSoftwareProfile condition to stronghold status and actions
* feat: move ledger state to profile modal

* feat: adds ledger icon next to profile name

* fix: fixes from code review

* fix: missing store isLedgerProfile subscription

* feat: add all ledger states to profile modal

* chore: remove old dashboard security file

* chore: remove old locales

Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
* feat: adds extra small button class

* feat: moves backup to profile modal

* fix: changes reactive variables lines

* feat: show backup in profile modal only when unsafe & improve locales

Co-authored-by: Begoña Alvarez <[email protected]>
* feat: adds backup to profile modal

* feat: display updater only when there is an update available

* feat: polish css

Co-authored-by: Begoña Alvarez <[email protected]>
* feat: adapt wallet balance ui

* fix: select account wrong reactivity

* fix: cleanup imports

* feat: show send/receive views on click

* feat: update tokens icons

* feat: add my assets

* feat: cleanup AccountTile

* feat: remove comment

* fix: account actions modal remount

* fix: delete account success leads to undefined selected account view
* fix: wrong profile modal logic for backup and ledger

* feat: polish css & fix wrong locale
maxwellmattryan and others added 16 commits July 27, 2022 15:08
* refactor: use local result files

* chore: fix gitignore

* fix: add delete files back

* test: fix these

* fix: adjust formatting
* refactor: use local result files

* chore: fix gitignore

* fix: add delete files back

* fix: staking reward display

* fix: account load and initial sync logic

Co-authored-by: Matthew Maxwell <[email protected]>
* fix: pass correct gap limit for bg syncing

* improvement: update positioning of syncing message

* fix: reset syncing queue on logout

* fix: account sync gap limit

* fix: manual sync gap limit
* fix: account update on balance change

* fix: rerender assets on staking cache completion

* fix: reset staking cache store on logout
@begonaalvarezd begonaalvarezd added the type:chore House-keeping etc. label Aug 9, 2022
@begonaalvarezd begonaalvarezd self-assigned this Aug 9, 2022
@begonaalvarezd begonaalvarezd marked this pull request as ready for review August 9, 2022 17:37
Copy link
Contributor

@amadeu2 amadeu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything on Android and iOS from scratch and it's working perfect! 💯 Tested also Stronghold import with previous history and funds, it was recovered all as espected 💫😁

@begonaalvarezd begonaalvarezd merged commit dd7a904 into develop Aug 11, 2022
@begonaalvarezd begonaalvarezd deleted the merge/desktop-1.6.5 branch August 11, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Balance is not updated after the stronghold import
9 participants