-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge tag desktop-1.6.5
into develop
#4189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Move `selectedAccount` to global state
feat: remove dead code
fix: ledger regenerate address
* chore: move viewableAccounts & liveAccounts to Dashboard.svelte to expose globally * feat: add top navigation with switcher modal * feat: improve css * feat: add max height to account switcher * fix: account switcher css * feat: rename AccountNavigation component to TopNavigation * feat: add missing top nav border * fix: restore DeveloperProfileIndicator * fix: css typo * fix: remove commented code * fix: remove unused locale * fix: dashboard flex height * fix: typing
* chore: move viewableAccounts & liveAccounts to Dashboard.svelte to expose globally * feat: add top navigation with switcher modal * feat: improve css * feat: add max height to account switcher * fix: account switcher css * feat: rename AccountNavigation component to TopNavigation * feat: add missing top nav border * fix: restore DeveloperProfileIndicator * fix: css typo * feat: add sidebar tab component with tooltips * fix: remove commented code * fix: remove unused locale * fix: dashboard flex height * fix: typing * fix: typing
* feat: adds stronghold status and action to profile modal * fix: polishes layout * fix: adds isSoftwareProfile condition to stronghold status and actions
* feat: move ledger state to profile modal * feat: adds ledger icon next to profile name * fix: fixes from code review * fix: missing store isLedgerProfile subscription * feat: add all ledger states to profile modal * chore: remove old dashboard security file * chore: remove old locales Co-authored-by: Begoña Álvarez de la Cruz <[email protected]>
* feat: adds extra small button class * feat: moves backup to profile modal * fix: changes reactive variables lines * feat: show backup in profile modal only when unsafe & improve locales Co-authored-by: Begoña Alvarez <[email protected]>
* feat: adds backup to profile modal * feat: display updater only when there is an update available * feat: polish css Co-authored-by: Begoña Alvarez <[email protected]>
* feat: adapt wallet balance ui * fix: select account wrong reactivity * fix: cleanup imports * feat: show send/receive views on click * feat: update tokens icons * feat: add my assets * feat: cleanup AccountTile * feat: remove comment * fix: account actions modal remount * fix: delete account success leads to undefined selected account view
* fix: wrong profile modal logic for backup and ledger * feat: polish css & fix wrong locale
* refactor: use local result files * chore: fix gitignore * fix: add delete files back * test: fix these * fix: adjust formatting
* refactor: use local result files * chore: fix gitignore * fix: add delete files back * fix: staking reward display * fix: account load and initial sync logic Co-authored-by: Matthew Maxwell <[email protected]>
* fix: pass correct gap limit for bg syncing * improvement: update positioning of syncing message * fix: reset syncing queue on logout * fix: account sync gap limit * fix: manual sync gap limit
* fix: account update on balance change * fix: rerender assets on staking cache completion * fix: reset staking cache store on logout
…/firefly into release/desktop-1.6.4
amadeu2
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested everything on Android and iOS from scratch and it's working perfect! 💯 Tested also Stronghold import with previous history and funds, it was recovered all as espected 💫😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes:
Had to move
haveStakingResultsCached
topackages/shared/lib/wallet.ts
because it was giving me circular dependency when it was defined inpackages/shared/lib/participation/participation.ts
Changelog
Relevant Issues
Closes #3951
Testing
Platforms
Instructions
...
Checklist