Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: polish UI #4838

Merged
merged 1 commit into from
Oct 10, 2022
Merged

enhancement: polish UI #4838

merged 1 commit into from
Oct 10, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Oct 10, 2022 •
edited
Loading

Summary

Get rid of the custom UI elements on the confirmation page

...

Changelog

- Remove custom elements from confirmation popup

Relevant Issues

closes: #4791

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from begonaalvarezd October 10, 2022 10:50
@Tuditi Tuditi requested a review from cvarley100 as a code owner October 10, 2022 10:50
@Tuditi Tuditi self-assigned this Oct 10, 2022
begonaalvarezd
begonaalvarezd approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@begonaalvarezd begonaalvarezd merged commit 0627593 into multichain-support Oct 10, 2022
@begonaalvarezd begonaalvarezd deleted the enhancement/polish-ui branch October 10, 2022 11:01
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@Tuditi Tuditi

Labels
type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tuditi @begonaalvarezd