Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: generic tag and metadata #4923

Merged
merged 7 commits into from
Oct 28, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Oct 18, 2022

Summary

This PR enables a tag and metadata being sent on the IOTA network.

...

Changelog

- Add tag and metadata for default send flow
- Add generic validation rules
- Disable only when transferring

Relevant Issues

closes: #4916
...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from begonaalvarezd October 18, 2022 15:53
@Tuditi Tuditi self-assigned this Oct 18, 2022
@Tuditi Tuditi requested a review from cvarley100 as a code owner October 18, 2022 15:53
@Tuditi Tuditi force-pushed the enhancement/generic-tag-and-metadata branch from 0a677a7 to 84fe477 Compare October 18, 2022 15:55
@Tuditi Tuditi linked an issue Oct 18, 2022 that may be closed by this pull request
3 tasks
@Tuditi Tuditi requested a review from nicole-obrien October 20, 2022 09:17
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to compress a bit the inputs because when anything validates the send & cancel button dissappear
image
Same happens with 2 inputs that do not validate
image
And with 1 they are partially hidden
image

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I also saw while testing:

@Tuditi Tuditi requested a review from begonaalvarezd October 27, 2022 15:52
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@Tuditi Tuditi merged commit 5c8f4d1 into multichain-support Oct 28, 2022
@Tuditi Tuditi deleted the enhancement/generic-tag-and-metadata branch October 28, 2022 15:43
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add generic tag and metadata support to deep links
2 participants