Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag & metadata support for deep links #5075

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 1, 2022

Summary

This PR adds support for tag & metadata in deep links. This can be used for bridgeing assets between chains and enabling use cases that require some form of data communication through the Tangle and FF.

...

Changelog

- Remove custom tag & metadata support from deep links
- Add generic support for tag & metadata
- Add byte length validation for tag & metadata

Relevant Issues

closes: #4924

...

Testing

It is required to build, compile and integrate Firefly to run the deep links. Here are some deep links to test with:

  • iota://wallet/send/atoi1qr5kcchl2nprvmel43njezhd0pa8xvh2fzlzsqdfwcuhyqa7cpu3gz5x55z/?amount=2.7&unit=Mi
  • iota://wallet/send/atoi1qz0mvjzjfwt5wcy8j8daw6avh67z77kquwkwzr5fvuu6pfzpjqgz7cptqex/?amount=2&unit=Mi&chainId=4002&receiverAddress=0x8A323cf02B18A59e209C66817A057a1000e0B712
  • iota://wallet/send/atoi1qz0mvjzjfwt5wcy8j8daw6avh67z77kquwkwzr5fvuu6pfzpjqgz7cptqex/?amount=1&unit=Mi&tag=swapOut&metadata=0xF65e3cCbe04D4784EDa9CC4a33F84A6162aC9EB6:4002
  • iota://wallet/send/atoi1qz0mvjzjfwt5wcy8j8daw6avh67z77kquwkwzr5fvuu6pfzpjqgz7cptqex/?amount=1&unit=Mi&tag=swapOut&metadata=${addError({ time: Date.now(), type: 'deepLink', message: 'Logged from deepLink'})}
  • iota://wallet/send/atoi1qz0mvjzjfwt5wcy8j8daw6avh67z77kquwkwzr5fvuu6pfzpjqgz7cptqex/?amount=1&unit=Mi&tag=swapOut&metadata=${console.log(1)}

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from begonaalvarezd November 1, 2022 13:41
@Tuditi Tuditi requested a review from cvarley100 as a code owner November 1, 2022 13:41
@Tuditi Tuditi self-assigned this Nov 1, 2022
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@Tuditi Tuditi merged commit e9b66a9 into multichain-support Nov 2, 2022
@Tuditi Tuditi deleted the feat/tag-metadata-deep-link-support branch November 2, 2022 13:10
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants