Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction details #5076

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 1, 2022

Summary

There is a bug concerning the recipient that was shown in the transaction history. This PR aims to fix it.

Once this has been merged it should be ported onto mobile as well!

...

Changelog

- Finds correct recipient from tx payload.

Relevant Issues

closes: #4521

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added bug report Something isn't working as intended type:fix Fix for bug package:desktop labels Nov 1, 2022
@Tuditi Tuditi requested a review from begonaalvarezd November 1, 2022 16:09
@Tuditi Tuditi self-assigned this Nov 1, 2022
@Tuditi Tuditi requested a review from cvarley100 as a code owner November 1, 2022 16:09
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@Tuditi Tuditi merged commit c47292b into multichain-support Nov 2, 2022
@Tuditi Tuditi deleted the fix/transaction-details branch November 2, 2022 08:30
Tuditi added a commit that referenced this pull request Nov 2, 2022
@Tuditi Tuditi mentioned this pull request Nov 2, 2022
12 tasks
Tuditi added a commit that referenced this pull request Nov 2, 2022
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something isn't working as intended type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants