Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move address validation to send address #5099

Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 3, 2022

Summary

Reverted address validation to parse send operation
...

Changelog

- Added explicit check for no address validation

Relevant Issues

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi requested a review from cvarley100 as a code owner November 3, 2022 10:41
@Tuditi Tuditi self-assigned this Nov 3, 2022
@Tuditi Tuditi force-pushed the chore/move-validation-to-send-operation branch from dea917f to 41ce9ee Compare November 3, 2022 11:15
@nicole-obrien nicole-obrien merged commit efdd0df into release/desktop-1.7.0 Nov 3, 2022
@nicole-obrien nicole-obrien deleted the chore/move-validation-to-send-operation branch November 3, 2022 11:16
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants