Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass dist-url flag & update wallet-rs revision hash #5794

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 7, 2023

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues (e.g. bug, task).

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi force-pushed the fix/pass-dist-url-flag branch from 6d2bfe6 to 7478e10 Compare February 7, 2023 15:26
@Tuditi Tuditi self-assigned this Feb 7, 2023
@Tuditi Tuditi marked this pull request as ready for review February 7, 2023 15:30
@Tuditi Tuditi requested a review from cvarley100 as a code owner February 7, 2023 15:30
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 works

@begonaalvarezd begonaalvarezd changed the title fix: pass dist-url flag fix: pass dist-url flag & update wallet-rs revision hash Feb 7, 2023
@begonaalvarezd begonaalvarezd merged commit 68b818e into main Feb 7, 2023
@begonaalvarezd begonaalvarezd deleted the fix/pass-dist-url-flag branch February 7, 2023 16:22
@rajivshah3 rajivshah3 mentioned this pull request May 17, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants