feat: set a primary key (account management) #8077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-management-list-ui
…ress and disable the password input
packages/desktop/views/dashboard/account-management/AccountManagement.svelte
…nt-info packages/desktop/views/dashboard/account-management/AccountManagement.svelte
…nt-info packages/desktop/views/dashboard/account-management/AccountManagement.svelte
packages/desktop/views/dashboard/account-management/AccountManagement.svelte
…count-in-details-view
…w' and 'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-logic-for-activate-account-in-details-view
cpl121
requested changes
Feb 20, 2024
marc2332
requested changes
Feb 22, 2024
marc2332
requested changes
Feb 22, 2024
…count-in-details-view
… into feat/set-a-primary-key
Base automatically changed from
feat/update-logic-for-activate-account-in-details-view
to
develop-iota2.0
February 22, 2024 16:20
marc2332
requested changes
Feb 23, 2024
| @@ -51,7 +51,7 @@ | |||
|
|
|||
| const explorerUrl = getOfficialExplorerUrl($activeProfile?.network?.id) | |||
|
|
|||
| $: isImplicitAccount = isImplicitAccountOutput(selectedOutput.output as CommonOutput) | |||
| $: isImplicitAccount = isImplicitAccountOutput(selectedOutput?.output as CommonOutput) | |||
There was a problem hiding this comment.
Why the ?, there will always be an output according to the SDK types
Suggested change
| $: isImplicitAccount = isImplicitAccountOutput(selectedOutput?.output as CommonOutput) | |
| $: isImplicitAccount = isImplicitAccountOutput(selectedOutput.output as CommonOutput) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Testing
Platforms
Instructions
...
Checklist