Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: claim rewards from delegation outputs #8136

Merged
merged 18 commits into from
Mar 12, 2024
Merged

feat: claim rewards from delegation outputs #8136

merged 18 commits into from
Mar 12, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Mar 5, 2024 •
edited
Loading

Closes #7990

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Mar 5, 2024 that may be closed by this pull request
[Task]: Claim rewards from delegation outputs #7990
Closed
cpl121 and others added 5 commits March 6, 2024 19:41
@cpl121 cpl121 marked this pull request as ready for review March 11, 2024 13:02
@cpl121 cpl121 requested a review from marc2332 March 11, 2024 13:02
marc2332
marc2332 requested changes Mar 12, 2024
View reviewed changes
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated
onConfirm: async () => {
await checkActiveProfileAuth(
async () => {
// TODO: Update the delegationId when https://github.com/iotaledger/firefly/issues/8188 is merged
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we don't have computeDelegationId we can use computeAccountId

@cpl121 cpl121 requested a review from marc2332 March 12, 2024 13:06
marc2332
marc2332 requested changes Mar 12, 2024
View reviewed changes
packages/desktop/views/dashboard/delegation/Delegation.svelte Outdated
// TODO: add logic to claim reward
function handleClaimRewards(outputId: string, delegationId: string): void {
if (delegationId === EMPTY_HEX_ID) {
// TODO: Update with computeDelegationId when https://github.com/iotaledger/firefly/issues/8188 is merged
Copy link
Collaborator

@marc2332 marc2332 Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8188 got closed, we can now use computeDelegationId

@cpl121 cpl121 requested a review from marc2332 March 12, 2024 16:09
cpl121 and others added 3 commits March 12, 2024 17:32
@cpl121 cpl121 requested a review from marc2332 March 12, 2024 16:33
cpl121 and others added 4 commits March 12, 2024 17:41
@cpl121
Merge branch 'feat/claim-rewards-from-delegation-outputs' of github.c…
c93c98b 
…om:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
@cpl121
Merge branch 'develop-iota2.0' of github.com:iotaledger/firefly into …
7256688 
…feat/claim-rewards-from-delegation-outputs
@cpl121
Merge branches 'feat/claim-rewards-from-delegation-outputs' and 'deve…
d674021 
…lop-iota2.0' of github.com:iotaledger/firefly into feat/claim-rewards-from-delegation-outputs
@cpl121
Merge branch 'develop-iota2.0' into feat/claim-rewards-from-delegatio…
8657243 
…n-outputs
begonaalvarezd
begonaalvarezd approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@cpl121 cpl121 merged commit 8abbc92 into develop-iota2.0 Mar 12, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/claim-rewards-from-delegation-outputs branch March 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Claim rewards from delegation outputs
3 participants
@cpl121 @begonaalvarezd @marc2332