Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear red notificator on dashboard redirect #8252

Merged
merged 6 commits into from
Mar 25, 2024
Merged

fix: clear red notificator on dashboard redirect #8252

merged 6 commits into from
Mar 25, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8234

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda linked an issue Mar 22, 2024 that may be closed by this pull request
[Task]: Clear red notificator on dashboard redirect #8234
Closed
@cpl121 cpl121 self-requested a review March 25, 2024 08:14
@evavirseda evavirseda requested a review from cpl121 March 25, 2024 08:58
@evavirseda evavirseda requested a review from cpl121 March 25, 2024 16:47
cpl121
cpl121 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@begonaalvarezd begonaalvarezd merged commit b3633ee into develop-iota2.0 Mar 25, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/clear-red-notificator branch March 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Clear red notificator on dashboard redirect
3 participants
@evavirseda @begonaalvarezd @cpl121