Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent wallet destroyed error #8338

Merged
merged 15 commits into from
Apr 22, 2024
Merged

fix: Prevent wallet destroyed error #8338

merged 15 commits into from
Apr 22, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented Apr 9, 2024 •
edited by cpl121
Loading

Depends on #8401
Closes #8326

@marc2332 marc2332 marked this pull request as ready for review April 19, 2024 11:14
@marc2332 marc2332 requested review from cpl121 and evavirseda April 19, 2024 11:14
@evavirseda evavirseda linked an issue Apr 19, 2024 that may be closed by this pull request
[Task]: Fix Wallet was destroyed crash #8326
Closed
@marc2332 marc2332 changed the base branch from develop-iota2.0 to chore/alpha-7-sdk April 22, 2024 07:24
@marc2332 marc2332 mentioned this pull request Apr 22, 2024
Merged
Base automatically changed from chore/alpha-7-sdk to develop-iota2.0 April 22, 2024 08:35
evavirseda
evavirseda approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpl121
cpl121 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the error in the base branch, but the code seems fine to me to avoid race conditions

@cpl121 cpl121 requested a review from begonaalvarezd April 22, 2024 12:24
@begonaalvarezd begonaalvarezd merged commit 1a1ee63 into develop-iota2.0 Apr 22, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/wallet-destroyed-error branch April 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd Awaiting requested review from begonaalvarezd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Fix Wallet was destroyed crash
4 participants
@marc2332 @evavirseda @cpl121 @begonaalvarezd