Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create delegation activity #8366

Merged
merged 12 commits into from
Apr 16, 2024
Merged

feat: create delegation activity #8366

merged 12 commits into from
Apr 16, 2024

Conversation

evavirseda
Copy link
Collaborator

Summary

Closes #8335

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda requested a review from cpl121 April 10, 2024 13:16
@evavirseda evavirseda linked an issue Apr 10, 2024 that may be closed by this pull request
[Task]: Create delegation activity #8335
Closed
@marc2332 marc2332 self-requested a review April 11, 2024 06:52
marc2332
marc2332 requested changes Apr 11, 2024
View reviewed changes
packages/shared/lib/core/wallet/utils/generateActivity/generateActivities.ts Outdated Show resolved Hide resolved
...ges/shared/lib/core/wallet/utils/generateActivity/generateActivitiesFromDelegationOutputs.ts Outdated Show resolved Hide resolved
...ges/shared/lib/core/wallet/utils/generateActivity/generateActivitiesFromDelegationOutputs.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/types/activities/base-activity.type.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateSingleDelegationActivity.ts Show resolved Hide resolved
packages/shared/locales/en.json Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateActivities.ts Show resolved Hide resolved
packages/shared/components/DelegationActivityDetails.svelte Outdated Show resolved Hide resolved
packages/shared/components/DelegationActivityDetails.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateSingleDelegationActivity.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from marc2332 April 11, 2024 07:56
cpl121
cpl121 requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add a tab like in account
Captura de pantalla de 2024-04-11 12-13-59

Adding in the delegation tab

  • ValidatorAddress
  • DelegatedAmount
  • DelegationId (?)
  • StartEpoch (?)
    wdyt?

packages/shared/components/tiles/tileContents/DelegationActivityTileContent.svelte Outdated Show resolved Hide resolved
@evavirseda evavirseda requested review from cpl121 and marc2332 April 11, 2024 14:25
cpl121
cpl121 requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much prettier 👏🏼
Captura de pantalla de 2024-04-12 10-39-16

last comment 🙏🏼

packages/shared/lib/core/wallet/utils/generateActivity/generateSingleDelegationActivity.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 April 12, 2024 08:55
@cpl121 cpl121 merged commit cff7a2e into develop-iota2.0 Apr 16, 2024
3 of 4 checks passed
@cpl121 cpl121 deleted the feat/create-delegation-activity branch April 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@marc2332 marc2332 marc2332 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Create delegation activity
3 participants
@evavirseda @marc2332 @cpl121