Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix types so CI passes #8395

Merged
merged 20 commits into from
Apr 19, 2024
Merged

fix: Fix types so CI passes #8395

merged 20 commits into from
Apr 19, 2024

Conversation

marc2332
Copy link
Collaborator

Closes #8387

Simply commented a lot of code that needs to be adapted to the new 2.0 changes, this way the CI is 🟢 .

@marc2332 marc2332 requested review from begonaalvarezd and removed request for begonaalvarezd April 18, 2024 13:11
@marc2332 marc2332 marked this pull request as ready for review April 18, 2024 14:24
@marc2332 marc2332 requested review from cpl121, begonaalvarezd and evavirseda and removed request for cpl121 and begonaalvarezd April 18, 2024 14:24
@evavirseda evavirseda linked an issue Apr 19, 2024 that may be closed by this pull request
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@cpl121 cpl121 merged commit 473d1c7 into develop-iota2.0 Apr 19, 2024
4 checks passed
@cpl121 cpl121 deleted the fix/types-temp branch April 19, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix check types
3 participants