Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to delegate when entering first the amount and then the validator #8416

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: unable to delegate when entering first the amount and then the validator #8416

merged 2 commits into from
Apr 22, 2024

Conversation

evavirseda
Copy link
Collaborator

…alidator

Summary

Closes #8413
...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@evavirseda evavirseda requested review from begonaalvarezd, cpl121 and marc2332 and removed request for begonaalvarezd April 22, 2024 13:10
@evavirseda evavirseda linked an issue Apr 22, 2024 that may be closed by this pull request
[Task]: Unable to delegate when entering first the amount and then the validator #8413
Closed
marc2332
marc2332 requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@marc2332 marc2332 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It is still not letting me delegate 🤔

marc2332
marc2332 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work now, perhaps I didn't have the latest changes

@begonaalvarezd begonaalvarezd merged commit 775c327 into develop-iota2.0 Apr 22, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/unable-to-delegate-when-entering-first-the-amount branch April 22, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc2332 marc2332 marc2332 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 Awaiting requested review from cpl121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Unable to delegate when entering first the amount and then the validator
3 participants
@evavirseda @begonaalvarezd @marc2332