Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: displayed mana in tx details #8426

Merged
merged 16 commits into from
Apr 26, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Apr 23, 2024

Closes #8334

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Apr 23, 2024 that may be closed by this pull request
@cpl121 cpl121 marked this pull request as ready for review April 25, 2024 15:27
@cpl121 cpl121 changed the title fix: displayed mana in tx details WIP fix: displayed mana in tx details Apr 25, 2024
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the majority of the txs, the block cost which is the mana that it should be displayed, is incorrect by a little. Maybe the slot is not taken precisely or something

@begonaalvarezd begonaalvarezd merged commit a43fc50 into develop-iota2.0 Apr 26, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/display-mana-in-tx-details branch April 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix displayed mana in tx details
4 participants