Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin form_urlencoded #1138

Merged
merged 11 commits into from
Mar 8, 2023
Merged

Pin form_urlencoded #1138

merged 11 commits into from
Mar 8, 2023

Conversation

eike-hass
Copy link
Collaborator

@eike-hass eike-hass commented Mar 3, 2023

Description of change

Pin form_urlencoded to avoid breaking change as described here.
Use workflows form support branch instead of the by now non-existent dev branch.
Prebuild Stronghold TS tests to avoid issue with ts-mocha on musl, leading to long build times, failures and random Wasm errors. Root cause is still unknown.
Fix TS Enum issue where Enums generated by NAPI where not correctly exported or declared. A fix was merged to the source repository, but until it is released we are using a local copy of rollup-plugin-dts.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

CI passes.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eike-hass eike-hass changed the base branch from main to support/v0.6 March 3, 2023 14:00
@eike-hass eike-hass added Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Mar 3, 2023
@eike-hass eike-hass requested a review from abdulmth March 3, 2023 15:08
@eike-hass eike-hass changed the title Chore/pin form urlencoded Pin form_urlencoded Mar 8, 2023
Copy link
Contributor

@PhilippGackstatter PhilippGackstatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eike-hass eike-hass merged commit b8b009d into support/v0.6 Mar 8, 2023
@eike-hass eike-hass deleted the chore/pin-form_urlencoded branch March 8, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants