Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2.0 nodejs): Add setStrongholdPassword for SecretManager #1807

Merged
merged 15 commits into from
Jan 10, 2024
Merged

feat(2.0 nodejs): Add setStrongholdPassword for SecretManager #1807

merged 15 commits into from
Jan 10, 2024

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Dec 21, 2023 •
edited
Loading

Depends on #1797 (sorry)

Description of change

Enables support for setStrongholdPassword in Nodejs's SecretManager

Type of change

  • Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@marc2332 marc2332 mentioned this pull request Dec 21, 2023
Merged
@marc2332 marc2332 marked this pull request as ready for review December 22, 2023 12:38
@Thoralf-M
Copy link
Member

Why does it depend on #1797? b67c812 works alone?

@marc2332
Copy link
Contributor Author

marc2332 commented Jan 8, 2024 •
edited
Loading

Why does it depend on #1797? b67c812 works alone?

It's true that they don't depend on each other but it was easier for me to test this in Firefly, sorry, we are kind of blocked by the two other PRs, this way was easier 🙏
I would review/merge the PRs in the order they were opened, sound good?

Thoralf-M
Thoralf-M previously approved these changes Jan 10, 2024
View reviewed changes
@marc2332 marc2332 requested a review from Thoralf-M January 10, 2024 16:50
Thoralf-M
Thoralf-M previously approved these changes Jan 10, 2024
View reviewed changes
@thibault-martinez thibault-martinez merged commit 381c972 into iotaledger:2.0 Jan 10, 2024
9 checks passed
@marc2332 marc2332 deleted the feat/2.0-nodejs-setStrongholdPassword-secret-manager branch January 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc2332 @Thoralf-M @thibault-martinez @DaughterOfMars