fix(iota): fix PTB upgrade command #4960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
iota-ci
added
dev-tools
DaughterOfMars
approved these changes
Jan 21, 2025
thibault-martinez
approved these changes
Jan 21, 2025
tzakian
pushed a commit
to MystenLabs/sui
that referenced
this pull request
Jan 22, 2025
# Description of change Fix the PTB upgrade command by converting the package_digest to a vector instead of an array, because the .pure() function otherwise doesn't add the required length prefix byte. Porting over iotaledger/iota#4960 ## Type of change - Bug fix (a non-breaking change which fixes an issue) ## How the change has been tested Upgrading a package with a PTB command: `sui client ptb --assign upgrade_cap @0x6ed2d8b8587fd559e19e1c9d17a9ce8349abe32ff423df73ddfa2056759e90fc --upgrade . upgrade_cap` https://testnet.suivision.xyz/txblock/44egvNom79HtLwQinXcpenLbYfex3QSDriGzBpfk58Yx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fix the PTB upgrade command by converting the package_digest to a vector instead of an array, because the .pure() function otherwise doesn't add the required length prefix byte.
Links to any relevant issues
Fixes #4870
Type of change
How the change has been tested
Upgrading a package with a PTB command:
iota client ptb --assign upgrade_cap @0x7ccc6c2fe6a509e6266b17e57a109f393f435a30da748c5168448958eb47d826 --upgrade "../../examples/move/nft" upgrade_caphttps://explorer.rebased.iota.org/txblock/58pRmAPgB2o7aebpmjWQYW3wcXnsEuVq5EYvjtK67XVG