Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iota-tx-test-runner/docs): documentation of init, run, publish , print-bytecode task commands #5128

Open
wants to merge 10 commits into
base: sc-platform/transactional-tests-syntax
Choose a base branch
from

Conversation

Dkwcs
Copy link
Contributor

@Dkwcs Dkwcs commented Jan 31, 2025

Description of change

Documentation of init,run, publish, print-bytecode task commands in order to have good usage perspective.

Links to any relevant issues

Fixes #5122.

Type of change

  • Documentation Fix

@Dkwcs Dkwcs added the documentation Improvements or additions to documentation label Jan 31, 2025
@Dkwcs Dkwcs requested a review from miker83z January 31, 2025 16:54
@Dkwcs Dkwcs self-assigned this Jan 31, 2025
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ❌ Failed (Inspect) Feb 6, 2025 10:25pm
apps-ui-kit ❌ Failed (Inspect) Feb 6, 2025 10:25pm
rebased-explorer ❌ Failed (Inspect) Feb 6, 2025 10:25pm
wallet-dashboard ❌ Failed (Inspect) Feb 6, 2025 10:25pm

Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since init, run, publish and print-bytecode are fundamental, I would move them up in the list (before "view-object").

For each example write the output that is found in the .exp file (use the real tests files if necessary).

crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
crates/iota-transactional-test-runner/syntax.md Outdated Show resolved Hide resolved
@miker83z
Copy link
Contributor

miker83z commented Feb 4, 2025

Pls also run dprint fmt


This command is **optional**, but if used, it must be the first command in the test sequence.

Command should be use:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Command should be use:
You should use the command:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

//# init [OPTIONS]
```

Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example:
#### Example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


### `print-bytecode`

Command reads a compiled Move binary and prints its bytecode instructions in a readable format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Command reads a compiled Move binary and prints its bytecode instructions in a readable format.
A command that reads a compiled Move binary and prints its bytecode instructions in a readable format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


#### What is the simulator mode?

This type of execution when we can control the checkpoint, epoch creation process and manually advance clock as needed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This type of execution when we can control the checkpoint, epoch creation process and manually advance clock as needed.
This type of execution allows control of the checkpoint and epoch creation process and manually advances the clock as needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

//# print-bytecode
```

Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example:
#### Example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
```

- Publishes transfer.move on-chain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Publishes transfer.move on-chain.
- Publishes `transfer.move` on-chain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

```

- Publishes transfer.move on-chain.
- acc1 is the sender.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- acc1 is the sender.
- `acc1` is the sender.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

--syntax <SYNTAX>: move syntax type (`source` or `ir`).
```

Example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Example:
### Example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with additional # :D

//# view-object 2,0
```

`test::transfer` should have been published already before `run` command execution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`test::transfer` should have been published already before `run` command execution.
`test::transfer` should have been published already before you can `run` the command execution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 319 to 320
- acc1 is the sender.
- @acc2 is an identifier of recepient address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- acc1 is the sender.
- @acc2 is an identifier of recepient address.
- `acc1` is the sender.
- `@acc2` is an identifier of recipient address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[transactional-test-runner] Document Init, Run, Publish, PrintBytecode commands
3 participants