Statemanager fixes #3340
Merged
Statemanager fixes #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemmsilva
approved these changes
Mar 19, 2024
dessaya
reviewed
Mar 19, 2024
| } | ||
|
|
||
| func getCommonState(state1, state2 State) map[kv.Key]*commonEntry { | ||
| result := make(map[kv.Key]*commonEntry) |
There was a problem hiding this comment.
If I understand correctly the size of this map will be O(#keys in the state). Is this intended to run in production? It might take a lot of RAM...
There was a problem hiding this comment.
It was running in tests only. But Equals method should be able to run in production too. I suppose, it would be enough to test the equality of TrieRoot in Equals. Will change that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes to State manager:
Block.Equalsmethod used instead of custom implementation in State manager testsState.Equalsmethod moved tostatepackager from state manager; it might be doing too much, but that is what I used in state manager tests.