stack walking scripts #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bp = ctx->bp; | ||
|
|
||
| // unrolled loop (MAXDEPTH): | ||
| if (!(key.ret[depth++] = get_frame(&bp))) goto out; |
There was a problem hiding this comment.
wow. that's a cool hack :)
proper stack support is #1 on my todo list.
There was a problem hiding this comment.
thanks! yes, once proper support exists (bpf_ routines) these scripts can be edited.
|
I was afraid that we'd have to wait for kernel stack trace support to get this type of tools working, but you've managed to get it working with unrolled probe_read. Awesome. Starting to play with it... |
| if (!ret || ret < __START_KERNEL_map) | ||
| return 0; | ||
| if (bpf_probe_read(bp, sizeof(*bp), (void *)*bp)) | ||
| bp = 0; |
There was a problem hiding this comment.
Just noticed (belatedly) while reading through the blog entry, shouldn't this be *bp = 0;?
|
Good catch, thanks. Plus I can simplify the test on line 89. Pull request forthcoming... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.