-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for combined recipe and linux networking v3 #108
Conversation
This is a draft PR and not ready for review. This will be ready for review one combined recipe P4 is tested on hardware |
94a4823
to
548d66d
Compare
636654f
to
8810339
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've suggested some possible improvements, mostly for readability.
ofproto/ofproto-dpif-xlate.c
Outdated
@@ -3242,6 +3268,7 @@ xlate_normal(struct xlate_ctx *ctx) | |||
&& flow->packet_type == htonl(PT_ETH) | |||
&& in_port && in_port->pt_mode != NETDEV_PT_LEGACY_L3 | |||
) { | |||
//Below function calls mac_learning_insert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Below function calls mac_learning_insert | |
// The function below calls mac_learning_insert |
8810339
to
9055c79
Compare
Add support for updating P4 tables for maintaining IP and mac addresses learnt from a flow with ARP response. This will be used when reconstructing L2 after IPSEC packet is decrypted Signed-off-by: nupuruttarwar <[email protected]>
9055c79
to
94a7dc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add support for updating P4 tables for maintaining IP and mac addresses learnt from a flow with ARP response. This will be used when reconstructing L2 after IPSEC packet is decrypted Signed-off-by: nupuruttarwar <[email protected]>
Add support for updating P4 tables for maintaining IP and mac addresses learnt from a flow with ARP response. This will be used when reconstructing L2 after IPSEC packet is decrypted Signed-off-by: nupuruttarwar <[email protected]>
No description provided.