Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for combined recipe and linux networking v3 #108

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

nupuruttarwar
Copy link
Collaborator

No description provided.

@nupuruttarwar
Copy link
Collaborator Author

This is a draft PR and not ready for review. This will be ready for review one combined recipe P4 is tested on hardware

@nupuruttarwar nupuruttarwar force-pushed the combined_rcp branch 2 times, most recently from 94a4823 to 548d66d Compare March 14, 2024 03:43
@nupuruttarwar nupuruttarwar force-pushed the combined_rcp branch 2 times, most recently from 636654f to 8810339 Compare April 2, 2024 00:23
@nupuruttarwar nupuruttarwar marked this pull request as ready for review April 2, 2024 00:23
Copy link

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've suggested some possible improvements, mostly for readability.

@@ -3242,6 +3268,7 @@ xlate_normal(struct xlate_ctx *ctx)
&& flow->packet_type == htonl(PT_ETH)
&& in_port && in_port->pt_mode != NETDEV_PT_LEGACY_L3
) {
//Below function calls mac_learning_insert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Below function calls mac_learning_insert
// The function below calls mac_learning_insert

Add support for updating P4 tables for maintaining IP and mac addresses
learnt from a flow with ARP response. This will be used when reconstructing L2
after IPSEC packet is decrypted

Signed-off-by: nupuruttarwar <[email protected]>
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nupuruttarwar nupuruttarwar merged commit 6b6f795 into ipdk-latest Apr 2, 2024
1 check passed
@nupuruttarwar nupuruttarwar deleted the combined_rcp branch April 2, 2024 20:27
ffoulkes pushed a commit that referenced this pull request May 29, 2024
Add support for updating P4 tables for maintaining IP and mac addresses
learnt from a flow with ARP response. This will be used when reconstructing L2
after IPSEC packet is decrypted

Signed-off-by: nupuruttarwar <[email protected]>
ffoulkes pushed a commit that referenced this pull request Jul 23, 2024
Add support for updating P4 tables for maintaining IP and mac addresses
learnt from a flow with ARP response. This will be used when reconstructing L2
after IPSEC packet is decrypted

Signed-off-by: nupuruttarwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants