Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise coverity fix #119

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Revise coverity fix #119

merged 1 commit into from
Jun 14, 2024

Conversation

ffoulkes
Copy link

  • Corrected length check preceding strncpy().
  • Revised error message to provide more information.

@ffoulkes
Revise coverity fix
0562c2f 
Signed-off-by: Derek Foster <[email protected]>
5abeel
5abeel approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5abeel 5abeel merged commit fa9b840 into fix_coverity_hit Jun 14, 2024
1 check passed
@5abeel 5abeel deleted the fix_coverity_fix branch June 14, 2024 17:29
5abeel added a commit that referenced this pull request Jun 14, 2024
@5abeel @ffoulkes
Manually terminate grpc addr string to address Coverity hit (#118)
8ffdd9e 
* Manually terminate grpc addr string to address Coverity hit

Signed-off-by: Sabeel Ansari <[email protected]>

* Revise coverity fix (#119)

Signed-off-by: Derek Foster <[email protected]>

---------

Signed-off-by: Sabeel Ansari <[email protected]>
Signed-off-by: Derek Foster <[email protected]>
Co-authored-by: Derek G Foster <[email protected]>
5abeel added a commit that referenced this pull request Jun 14, 2024
@5abeel @ffoulkes
Manually terminate grpc addr string to address Coverity hit (#118)
a89061f 
* Manually terminate grpc addr string to address Coverity hit

Signed-off-by: Sabeel Ansari <[email protected]>

* Revise coverity fix (#119)

Signed-off-by: Derek Foster <[email protected]>

---------

Signed-off-by: Sabeel Ansari <[email protected]>
Signed-off-by: Derek Foster <[email protected]>
Co-authored-by: Derek G Foster <[email protected]>
@5abeel 5abeel mentioned this pull request Jun 14, 2024
Merged
ffoulkes added a commit that referenced this pull request Jun 14, 2024
@5abeel @ffoulkes
Manually terminate grpc addr string to address Coverity hit (#118) (#120
0c4b5a2 
)

- Manually terminate grpc addr string to address Coverity hit
- Revise coverity fix (#119)

Signed-off-by: Sabeel Ansari <[email protected]>
Signed-off-by: Derek Foster <[email protected]>
Co-authored-by: Derek G Foster <[email protected]>
ffoulkes added a commit that referenced this pull request Jul 23, 2024
@5abeel @ffoulkes
Manually terminate grpc addr string to address Coverity hit (#118) (#120
edd4944 
)

- Manually terminate grpc addr string to address Coverity hit
- Revise coverity fix (#119)

Signed-off-by: Sabeel Ansari <[email protected]>
Signed-off-by: Derek Foster <[email protected]>
Co-authored-by: Derek G Foster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@nupuruttarwar nupuruttarwar Awaiting requested review from nupuruttarwar

@n-sandeep n-sandeep Awaiting requested review from n-sandeep

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @5abeel