-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish r5r paper #108
Comments
Paper submitted to Transport Findings. See files in commit 11a6d2d5cd441c278dad9cc52a2ff46d522157d1 |
The comments from the journal are in. We've received really positive feedback from reviewer # 1, and a puzzling comment from reviewer # 2. See below. Editor
Reviewer 1
Rating scale questions
Reviewer 2
Rating scale questions
|
Here is a gist with code to create a travel time matrix using Some comments:
|
Hi all. Here is our response to the reviewers. Please feel free to suggest any changes. Tagging @mattwigway to join the conversation. Reviewer 1
Reviewer 2We appreciate the reviewer's suggestion. The aim of the paper is to introduce and demonstrate a new computational tool. As such, this manuscript is not intended to articulate a substantial research question, but rather to provide a tool/method that could be used to address a variety of questions that require the calculation of travel matrices or the examination of multimodal transport routes. We changed the last paragraph of the first section of the paper to make this point clearer in the text. The paragraph reads as follows (changes in bold):
Regarding the performance comparison between r5r and the opentripplanner R package. We have conducted a benchmark comparison and we found that r5r is 2054 times faster than opentripplanner (reproducible code can be found here https://gist.github.com/dhersz/14c4b7927a9ef91aeddcc3bf8bd0712a). However, we should note that opentripplanner focuses on point-to-point routing, returning all the spatial geometries of rotes. Because the outputs of the two packages are different, we believe this would not be a fair comparison and so we decided not to include it in the manuscript. |
Sorry, just seeing this now - the reviews seem promising and I'm fine with the proposed changes to the manuscript. Just a few thoughts:
Regarding the performance comparison between r5r and the opentripplanner R package. We have conducted a benchmark comparison and we found that r5r is 2054 times faster than opentripplanner on the example dataset used in this paper (reproducible code can be found here https://gist.github.com/dhersz/14c4b7927a9ef91aeddcc3bf8bd0712a). However, we should note that opentripplanner focuses on point-to-point routing, so it runs the routing algorithm for each O-D pair. However, due to the nature of the graph search process used in routing, finding a route from an origin to a destination also finds routes to all places closer to the origin than the destination. R5 takes advantage of this to compute an entire row of the travel time matrix simultaneously, while opentripplanner runs the routing algorithm once per O-D pair. Thus, the computation time for r5r scales near-linearly with the number of origins, regardless of the number of destinations, while opentripplanner computation times scale with the product of the number of origins and destinations. Thus, the ratio of computation times will vary significantly depending on the dataset, but for any substantial travel time matrix Not part of my proposed changes, but a caveat to the above:
|
I suppose to satisfy Reviewer 2 we could add something similar to what I wrote above to the manuscript when we talk about how this is different from what came before. We could add a paragraph comparing the computational approaches of r5r and opentripplanner/dodgr/stplanr. I can draft something. |
Hi @mattwigway . Thanks for the detailed answer. I'm glad to incorporated the changes you suggested in our response to reviewer 2. I would be glad to include a paragraph comparing the computational approaches of different packages. However, I don't know it would be possible to make an informative and yet short paragraph. We are already over the word-count limit. What do you think? |
I drafted a paragraph in #151. I'm fine though if you don't want to include it, it is a bit of a complex point. |
Ok, that's very succinct! Thanks. I think we should included it, for sure. |
Great! I'm good with final submission at this point.
…On Wed, Feb 24, 2021, 7:21 PM Rafael H M Pereira ***@***.***> wrote:
Ok, that's very succinct! Thanks. I think we should included it, for sure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKNLU3V7MPVU6KZRVVASLTAWJXRANCNFSM4QT45RCA>
.
|
Paper resubmitted. |
Awesome, thanks @rafapereirabr |
Hi all. The editor has sent an email with the good news that our paper has been accepted! |
Good news. Our paper is now published online. Thank you all for the contributions! I will be include the reference to this paper as the |
No description provided.
The text was updated successfully, but these errors were encountered: