-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dev brach to bring new developments to master #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # java-r5rcore/src/org/ipea/r5r/R5RCore.java
…ta_path directory, in `setup_r5()`
Fixing bug where topography was not considered when walking between transit stops
Added variables to globalVariables list in zzz, to avoid warning messages Fixed bug where direct walking and cycling trips were not returned by detailed_itineraries
…s code from R5RCore to other classes - Focus on IsochroneBuilder class
…s code from R5RCore to other classes - Focus on IsochroneBuilder class
…s code from R5RCore to other classes - Reorganising folder structure
…s code from R5RCore to other classes - Reorganising folder structure
…s code from R5RCore to other classes - Focus on StreetNetwork class, used by `street_network_to_sf()`
…s code from R5RCore to other classes - Moved code from IsochroneBuilder to R5Process superclass, which will be shared with TravelTimeMatrixComputer and DetailedItineraryPlanner
…s code from R5RCore to other classes - Focus on DetailedItineraryPlanner
…ty()` function. Added `assert_decay_function()` in utils.R to check for valid inputs for `decay_function` and `decay_value` parameters.
…verbose = FALSE` (Issue #150). Small tweaks in the documentation.
…, and `accessibility functions`. Issue #174
…trix()`, and `detailed_itineraries()` tests. Issue #174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
New function
accessibility()
to calculate access to opportunities. Closes #169New function
find_snap()
to help the used identify where in the street networkthe input of origin and destination points are snapped to. Closes 168.
New parameter
max_bike_dist
added to routing and accessibility functions. Closes #174Implemented temporary solution for elevation. Closes #171. Now r5r can read Digital Elevation Model (DEM) data from raster files in
.tif
format to weight thestreet network for walking and cycling according to the terrain's slopes. Ideally, we would like to see a solution that accounts for elevation implemented upstream in R5. For now, this is a temporary solution implemented within r5r.