Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vsmgr): implement strict check of check provable #452

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

remakeZK
Copy link
Contributor

@remakeZK remakeZK commented Sep 29, 2022

关联的Issues (Related Issues)

close #401
close #430

改动 (Proposed Changes)

完善了checkprovable的代码,现在会对每个扇区进行vanillaproof的校验

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@remakeZK remakeZK added the vsmgr vsmgr related issue label Sep 29, 2022
@remakeZK remakeZK added this to the v0.5.0 milestone Sep 29, 2022
@remakeZK remakeZK self-assigned this Sep 29, 2022
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 8e80dc9 into main Oct 9, 2022
@diwufeiwen diwufeiwen deleted the feat/wc/implement_strict_check_provable branch October 9, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsmgr vsmgr related issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

VSM能否完善proving check --slow 功能? check --slow 扇区并没有执行扇区的验证
2 participants