Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor updatedealstatus api #640

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Feb 28, 2023

关联的Issues (Related Issues)

close #602

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合 Venus 项目管理规范中关于 PR 的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的 commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Feb 28, 2023
@0x5459
Copy link
Collaborator

0x5459 commented Feb 28, 2023

vsm 依赖的版本改动是不是有点问题? @diwufeiwen

-github.com/filecoin-project/venus v1.10.0-rc4
+github.com/filecoin-project/venus v1.10.0-rc2.0.20230227093744-be646f4a8be5

@diwufeiwen
Copy link
Contributor Author

vsm 依赖的版本改动是不是有点问题? @diwufeiwen

-github.com/filecoin-project/venus v1.10.0-rc4
+github.com/filecoin-project/venus v1.10.0-rc2.0.20230227093744-be646f4a8be5

还没让你review,你咋这么积极?

@diwufeiwen diwufeiwen force-pushed the feat/lt/refactor_updatedealstatus_api branch from c4c617a to 3da0d62 Compare March 2, 2023 05:10
@0x5459 0x5459 force-pushed the feat/lt/refactor_updatedealstatus_api branch from 3da0d62 to 47d81c3 Compare March 2, 2023 05:59
Copy link
Collaborator

@0x5459 0x5459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5459 0x5459 merged commit 1ec3d13 into main Mar 2, 2023
@0x5459 0x5459 deleted the feat/lt/refactor_updatedealstatus_api branch March 2, 2023 06:28
@0x5459 0x5459 mentioned this pull request Mar 2, 2023
5 tasks
diwufeiwen added a commit that referenced this pull request Mar 2, 2023
…release/v0.5

Cherry-pick #640 to `release/v0.5`
@0x5459 0x5459 mentioned this pull request Mar 2, 2023
5 tasks
diwufeiwen added a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

[vsm] 在对订单进行 release-deals 时,并未修改 state 字段。导致订单不能被释放出来
2 participants