Feat: auto migration badger/badger数据自动迁移 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zl03jsj
changed the title
zl03jsj
force-pushed
the
feat/auto-migratoin-badger-from-v2.2.0
branch
from
bf8a845 to
f921dbc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 24.06% 25.32% +1.25%
==========================================
Files 178 181 +3
Lines 19337 20753 +1416
==========================================
+ Hits 4654 5256 +602
- Misses 14117 14676 +559
- Partials 566 821 +255
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zl03jsj
force-pushed
the
feat/auto-migratoin-badger-from-v2.2.0
branch
from
305f318 to
be3fc20
Compare
hunjixin
approved these changes
Oct 17, 2022
zl03jsj
force-pushed
the
feat/auto-migratoin-badger-from-v2.2.0
branch
from
d1e7826 to
dc1b684
Compare
diwufeiwen
reviewed
Oct 17, 2022
| ) | ||
|
|
||
| const ( | ||
| DsNameFundedAddrState = "FundedAddrStateDs" |
|
|
||
| if !exist { | ||
| dss[name] = ds | ||
| log.Warnf("no migration sechedules for : %s", name) |
There was a problem hiding this comment.
是写错了, 应该是'schedule'
| } | ||
| var versionedDs datastore.Batching | ||
| versionedDs, err = migrateOne(ctx, name, mfs, ds) | ||
| // todo: version为空同时, 有同时存在两个版本的类型的可能性, 为了兼容, 这里暂时不返回错误. |
There was a problem hiding this comment.
[doge]原因是, 中间有几个提交, 类型已经升级了, 但是还没有引入自动迁移的功能.为了兼容, 所以这里暂时不返回错误, 等到下个版本之后, 这里就可以直接返回错误了.
There was a problem hiding this comment.
是说这句话不通顺，什么是“为空同时”
为空时, hand slipped..
| log.Infof("migrate: %s from %s to %s", name, oldVersion, string(targetVersion)) | ||
| mfs = mfs.subScheduleFrom(oldVersion) | ||
| if len(mfs) == 0 { | ||
| return nil, fmt.Errorf("migrate:%s failed, can't find schedule from:%s", name, oldVersion) |
There was a problem hiding this comment.
这里是开发者需要保证对应的迁移必须存在, 所以, 这里正常情况是肯定存在的, 如果不存在,说明是代码写错了.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
closes filecoin-project/venus#5283
改动 (Proposed Changes)
附注 (Additional Info)
自查清单 (Checklist)
如果为master分支中commit为如下区间的升级
595369d 2022-10-14 ... 9a21e00 2022-09-09日志中包含迁移错误信息是正常现象, 因为这几个版本中的数据已经是新的格式了,但在这几个版本中还未加入自动迁移功能.所以会有这样的错误日志:
如果为
9a21e00 2022-09-09之前的,数据则为老版本, 能看到正常迁移的日志, 不会出现任何迁移失败的错误日志: