Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deal expired check #232

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Nov 4, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#5447

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin force-pushed the feat/add_check_deal_expired branch 2 times, most recently from 1eb8597 to 6ed6295 Compare November 4, 2022 05:19
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

storageprovider/deal_tracker.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #232 (80c05cc) into master (4a24cee) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   25.14%   25.13%   -0.02%     
==========================================
  Files         181      181              
  Lines       20817    20830      +13     
==========================================
  Hits         5235     5235              
- Misses      14761    14774      +13     
  Partials      821      821              
Flag Coverage Δ
unittests 25.13% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storageprovider/deal_tracker.go 0.00% <0.00%> (ø)
paychmgr/simple.go 79.27% <0.00%> (ø)
cmd/market-client/storage.go 0.00% <0.00%> (ø)
storageprovider/ondealsectorcommitted.go 0.00% <0.00%> (ø)
storageprovider/deal_handler.go 4.11% <0.00%> (+<0.01%) ⬆️

@hunjixin hunjixin force-pushed the feat/add_check_deal_expired branch from 80c05cc to 201583a Compare November 4, 2022 08:29
@hunjixin hunjixin requested a review from remakeZK November 4, 2022 08:46
Copy link
Contributor

@remakeZK remakeZK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remakeZK remakeZK merged commit d663b0d into master Nov 4, 2022
@remakeZK remakeZK deleted the feat/add_check_deal_expired branch November 4, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market]cluster获取到过期的订单
4 participants