This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: bubble up 502 and 504 from backend #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
lidel
reviewed
Feb 23, 2023
There was a problem hiding this comment.
Thanks!
We need to park this until:
- feat(gateway): improved error handling, support for 502 and 504 ipfs/boxo#182 lands
- Saturn L1s add mapping from Lassie to either 502, or 504 (currently they just forward 404s)
- Caboose passes codes to us (Downvoting of Saturn L1s should consider the return codes from L1s filecoin-saturn/caboose#28)
lidel
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thank you.
I've pushed small fix to account for latest caboose which deals with artizan Lassie response codes: filecoin-saturn/caboose@a1f20de
We now return clear 504 Gateway Timeout on timeout, and 502 Bad Gateway for all other errors from Saturn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #50.
Fixes #35.
See ipfs/boxo#182.