This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
add go module support #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM bug @magik6k is the expert here. |
magik6k
approved these changes
Jan 30, 2019
|
(you can test this by copying golang pipeline code into |
|
Can we merge this so that libp2p/go-libp2p-kad-dht#236 can go in too? |
raulk
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Oh dear, I hate Groovy but this looks sane. I suggest we take it for a spin in libp2p/go-libp2p-kad-dht#236 as @magik6k suggests.
raulk
reviewed
Jan 30, 2019
| bat 'gx --verbose install --global' | ||
| bat 'gx-go rewrite' | ||
| } else { | ||
| bat 'go mod download' |
There was a problem hiding this comment.
nit: our gomod path triggers whenever the user provides a value for dep and iff the value is anything other than gx, not necessarily go-mod as the README.md suggests.
|
Can this be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to actually go about testing this PR. Happy to do it with some guidance.