Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

JSON.parse error reporting: with invalid json: in the error string #1001

Closed
wants to merge 6 commits into from
Closed

JSON.parse error reporting: with invalid json: in the error string #1001

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a6f291
Update stream-to-json-value.js
KrishnaPG May 16, 2019
1d5e41e
parseError taking non-JSON into account
KrishnaPG May 16, 2019
d2d970d
data should be non-empty (in addition to being non-null)
KrishnaPG May 16, 2019
ff6d63b
Moved isJson identification into a function
KrishnaPG May 17, 2019
aaef3cb
removing trailing-space as per the lint
KrishnaPG May 17, 2019
e79b711
adding status code to the error
KrishnaPG May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/stream-to-json-value.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function streamToJsonValue (res, cb) {
try {
res = JSON.parse(data)
} catch (err) {
return cb(err)
return cb(new Error(`Invalid JSON: ${data}`))
}

cb(null, res)
Expand Down