Bring back the PR #672

daviddias · 2018-01-19T03:02:09Z

daviddias · 2018-01-19T03:04:42Z

Something weird happened with #669 and code is missing causing these errors:

  1) stats
       .stats.bitswap:
     Uncaught AssertionError: expected { Object (ProvideBufLen, Wantlist, ...) } to have property 'provideBufLen'
      at ipfs.stats.bitswap (test/stats.spec.js:33:29)
      at f (node_modules/once/once.js:25:25)
      at streamToValue (node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
      at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
      at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:36:43)
      at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at endWritable (node_modules/readable-stream/lib/_stream_writable.js:615:3)
      at ConcatStream.Writable.end (node_modules/readable-stream/lib/_stream_writable.js:571:41)
      at IncomingMessage.onend (_stream_readable.js:595:10)
      at endReadableNT (_stream_readable.js:1056:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)

  2) stats
       .stats.bw:
     Uncaught AssertionError: expected { Object (TotalIn, TotalOut, ...) } to have property 'totalIn'
      at ipfs.stats.bw (test/stats.spec.js:50:29)
      at send.andTransform (node_modules/ipfs-api/src/stats/bw.js:23:7)
      at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
      at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:36:43)
      at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at endWritable (node_modules/readable-stream/lib/_stream_writable.js:615:3)
      at ConcatStream.Writable.end (node_modules/readable-stream/lib/_stream_writable.js:571:41)
      at DestroyableTransform.onend (node_modules/readable-stream/lib/_stream_readable.js:570:10)
      at endReadableNT (node_modules/readable-stream/lib/_stream_readable.js:992:12)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)

  3) stats
       .stats.repo:
     Uncaught AssertionError: expected { Object (NumObjects, RepoSize, ...) } to have property 'numObjects'
      at ipfs.stats.repo (test/stats.spec.js:62:29)
      at f (node_modules/once/once.js:25:25)
      at streamToValue (node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
      at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
      at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:36:43)
      at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at afterWrite (node_modules/readable-stream/lib/_stream_writable.js:470:3)
      at _combinedTickCallback (internal/process/next_tick.js:144:20)
      at process._tickDomainCallback (internal/process/next_tick.js:218:9)

Could you check what's happening? Also @dryajov

dryajov · 2018-01-19T03:05:30Z

@diasdavid I believe I know what the issue with the PR is - we need to use the current ipfs-api -

    df.spawn((err, _ipfsd) => {
      expect(err).to.not.exist()
      ipfsd = _ipfsd
      ipfs = IPFSApi(_ipfsd.apiAddr)
      done()
    })

I'm making the change right now.

dryajov · 2018-01-19T03:06:01Z

the relevant line in the above comment is ipfs = IPFSApi(_ipfsd.apiAddr)

dryajov · 2018-01-19T04:14:17Z

depends on ipfs-inactive/interface-js-ipfs-core#203

daviddias · 2018-01-19T16:46:47Z

released the fixed interface-ipfs-core and spinned up the CI here again. Waiting to get a confirmation.

dryajov · 2018-01-19T18:21:56Z

@diasdavid looking into ci issues

dryajov · 2018-01-20T03:10:30Z

@diasdavid @victorbjelkholm something is up with jenkins, the builds are not running.

dryajov · 2018-01-20T03:30:41Z

hmm, travis is giving a JavaScript heap out of memory, not sure if its due to the new ipfsd-ctl or travis is being travis. Would be nice to see if this runs in jenkins, so far circle is green :)

dryajov · 2018-01-20T03:34:54Z

I'll profile the test run tomorrow see where things might be going wrong.

dryajov · 2018-01-20T03:35:33Z

btw, coverage is back to a reasonable level.

dryajov · 2018-01-20T19:52:13Z

requires - ipfs/js-ipfsd-ctl#184

daviddias · 2018-01-21T00:15:15Z

btw, coverage is back to a reasonable level.

What created the massive drop?

daviddias · 2018-01-21T05:09:24Z

released ipfs/js-ipfsd-ctl#184, spinning CI here again

dryajov · 2018-01-21T06:14:15Z

It was due to the fact that ipfs-api was not being consumed directly, but through ipfsd-ctl which was wrong in the context of ipfs-api testing. Ding IpfsApi(ipfsd-ctl.apiAddr) fixes that.

daviddias · 2018-01-21T21:49:12Z

Every CI is failing. Circle with:

  4 failing

  1) .object,promise API,object.patch
       .addLink:
     Error: unexpected multihash type: undefined
    at module.exports (test/interface/object.spec.js:7360:11)
    at Function.promisify (test/interface/object.spec.js:81172:19)
    at test/interface/object.spec.js:111:20
    at new Promise (<anonymous>)
    at Object.addLink (test/interface/object.spec.js:105:16)
    at Promise.then (test/interface/object.spec.js:119397:40)
    at <anonymous>

  

  2) .object,promise API,object.patch
       .rmLink:
     Error: unexpected multihash type: undefined
    at module.exports (test/interface/object.spec.js:7360:11)
    at Function.promisify (test/interface/object.spec.js:81217:19)
    at test/interface/object.spec.js:111:20
    at new Promise (<anonymous>)
    at Object.rmLink (test/interface/object.spec.js:105:16)
    at Context.it (test/interface/object.spec.js:119407:36)

  

  3) .object,promise API,object.patch
       .appendData:
     Error: unexpected multihash type: undefined
    at module.exports (test/interface/object.spec.js:7360:11)
    at Function.promisify (test/interface/object.spec.js:81307:19)
    at test/interface/object.spec.js:111:20
    at new Promise (<anonymous>)
    at Object.appendData (test/interface/object.spec.js:105:16)
    at Context.it (test/interface/object.spec.js:119414:36)

  

  4) .object,promise API,object.patch
       .setData:
     Error: unexpected multihash type: undefined
    at module.exports (test/interface/object.spec.js:7360:11)
    at Function.promisify (test/interface/object.spec.js:81307:19)
    at test/interface/object.spec.js:111:20
    at new Promise (<anonymous>)
    at Object.appendData (test/interface/object.spec.js:105:16)
    at Context.it (test/interface/object.spec.js:119421:36)

Travis runs out of memory. I believe that it is trying to webpack stuff it doesn't need and crashes because of that.

dryajov · 2018-01-22T20:10:25Z

@diasdavid There seem to be two issues with the tests, at least in circleci - travis seems to be failing on a different error

Tests timeout at least %40 of the time, which is what causes the cascading failures you pasted in the prev comment
When running the full suit of tests, after successfully completing all the tests, chrome aegir/karma/mocha doesn't exit correctly (or takes longer than expected) causing Chrome/karma to timeout

I haven't been able to reproduce either of this failures locally, so it makes it a little harder to troubleshoot. I can run the builds with ssh enabled, which should allow me to trouble shoot it on circle directly.

dryajov · 2018-01-23T17:48:21Z

ok, increasing the browserNoActivityTimeout to 100 * 1000 fixed the karma timeout issue. I'm guessing that with ipfsd-ctl there is a little more overhead when running in the browser since it has to do a request and wait for a response from the REST endpoints.

daviddias · 2018-01-23T22:16:28Z

Ok, only tests missing is the Windows PubSub failing tests. LGTM :)

dryajov and others added 8 commits January 18, 2018 18:17

feat: use new ipfsd-ctl

12e6da2

fix: avoid too many changes

1220843

chore: adding go-ipfs-dep

0024569

feat: use new ipfsd-ctl

3ce88a3

fix: avoid too many changes

04eeff5

chore: upping ipfsd-ctl version

f628dab

chore: bump interface-ipfs-core

9fa4708

fix: timeouts

74ecf1c

ghost assigned daviddias Jan 19, 2018

ghost added the in progress label Jan 19, 2018

daviddias assigned dryajov and hacdias and unassigned daviddias Jan 19, 2018

daviddias and others added 4 commits January 18, 2018 23:17

clean bitswap tests

01d7c16

feat: use the current ipfs-api

af4dd75

fix: setup interface test node in ipfs-api

d32b03d

feat: destroy multiple nodes

43f4891

dryajov force-pushed the feat/ipfsd-ctl branch from cb8257b to 43f4891 Compare January 19, 2018 05:17

various fixes

ff36cef

fix: increase browserNoActivityTimeout

a6765d7

daviddias merged commit 2b1820b into master Jan 23, 2018

daviddias deleted the feat/ipfsd-ctl branch January 23, 2018 22:17

ghost removed the in progress label Jan 23, 2018

hsanjuan unassigned hacdias Apr 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring back the PR #672

Bring back the PR #672

daviddias commented Jan 19, 2018 •

edited

Loading

daviddias commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 19, 2018

daviddias commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

daviddias commented Jan 21, 2018

daviddias commented Jan 21, 2018

dryajov commented Jan 21, 2018

daviddias commented Jan 21, 2018

dryajov commented Jan 22, 2018

dryajov commented Jan 23, 2018

daviddias commented Jan 23, 2018

Bring back the PR #672

Bring back the PR #672

Conversation

daviddias commented Jan 19, 2018 • edited Loading

daviddias commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 19, 2018

daviddias commented Jan 19, 2018

dryajov commented Jan 19, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

dryajov commented Jan 20, 2018

daviddias commented Jan 21, 2018

daviddias commented Jan 21, 2018

dryajov commented Jan 21, 2018

daviddias commented Jan 21, 2018

dryajov commented Jan 22, 2018

dryajov commented Jan 23, 2018

daviddias commented Jan 23, 2018

daviddias commented Jan 19, 2018 •

edited

Loading