Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

GC endpoint #992

Merged
merged 4 commits into from
Jul 10, 2019
Merged

GC endpoint #992

merged 4 commits into from
Jul 10, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 10, 2019 •
edited
Loading

BREAKING CHANGE: repo.gc response objects have changed to { err, cid }

Depends on:

@ghost ghost assigned dirkmc May 10, 2019
@ghost ghost added the in progress label May 10, 2019
@dirkmc dirkmc mentioned this pull request May 23, 2019
Merged
11 tasks
alanshaw
alanshaw previously approved these changes Jul 5, 2019
View reviewed changes
@alanshaw alanshaw dismissed their stale review July 5, 2019 14:03

Thought of something after approving!

alanshaw
alanshaw suggested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also updating the repo.gc docs so people know what the shape of the return value is?

src/repo/gc.js Outdated Show resolved Hide resolved
src/repo/gc.js Outdated Show resolved Hide resolved
@dirkmc dirkmc mentioned this pull request Jul 9, 2019
Merged
@dirkmc
Copy link
Contributor Author

dirkmc commented Jul 9, 2019

repo.gc() docs fix: ipfs-inactive/interface-js-ipfs-core#492

@dirkmc dirkmc requested a review from alanshaw July 9, 2019 14:27
@alanshaw alanshaw merged commit 63d2125 into master Jul 10, 2019
@alanshaw alanshaw deleted the feat/gc branch July 10, 2019 08:59
@alanshaw alanshaw mentioned this pull request Jul 10, 2019
Closed
alanshaw pushed a commit to ipfs/js-ipfs that referenced this pull request Aug 26, 2019
@dirkmc
feat: garbage collection (#2022)
44045b0 
resolves #2012

Depends on
- [x] #2004
- [x] ipfs-inactive/js-ipfs-http-client#992
- [x] ipfs-inactive/interface-js-ipfs-core#462
- [x] achingbrain/mortice#1

TODO:
- [x] Core (mark and sweep)
- [x] CLI
- [x] http interface
- [x] interface-js-ipfs-core tests ipfs-inactive/interface-js-ipfs-core#462
- [x] nodejs-specific tests
- [x] Locking
- [x] Tests for locking
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@dirkmc dirkmc

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @alanshaw