Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove node-fetch #303

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jun 27, 2023

Remove node-fetch and use native fetch

fixes #57

@SgtPooki SgtPooki requested a review from a team as a code owner June 27, 2023 20:34
@SgtPooki SgtPooki requested a review from whizzzkid June 27, 2023 23:01
@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 3, 2023

ping @whizzzkid

Copy link

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocker nit

src/clientFromServiceAndTokenPair.ts Outdated Show resolved Hide resolved
@SgtPooki SgtPooki merged commit 750b1db into main Jul 17, 2023
@SgtPooki SgtPooki deleted the 57-explore-replacing-node-fetch-dependency-with-undicis-fetch-implementation branch July 17, 2023 19:28
github-actions bot pushed a commit that referenced this pull request Jul 17, 2023
## [1.7.0](v1.6.0...v1.7.0) (2023-07-17)

### Features

* remove node-fetch ([#303](#303)) ([750b1db](750b1db))
@github-actions
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore replacing node-fetch dependency with undici's fetch implementation
2 participants