feat: add -p flag to dependency-check to only check prod deps #672
Conversation
Adds a convenience flag to only check for missing production deps. Also allows the user to pass files to check instead of always using the defaults. Also, also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up. Would have caught ipfs/js-ipfs#3393
achingbrain
force-pushed
the
feat/allow-passing-input-to-dep-check
branch
from
de08f3a to
8cf33dc
Compare
src/dependency-check.js
Outdated
| let input = argv.input | ||
|
|
||
| if (argv.productionOnly) { | ||
| if (!hasPassedFileArgs(processArgs)) { |
There was a problem hiding this comment.
No, from what I can see, there's no way to tell if a value came from a passed argument or if it came from the defaults.
You could compare the input to the defaults, but if they entered the defaults you'd end up throwing them away. 😞
There was a problem hiding this comment.
the defaults are only used below so input should be empty right ?
There was a problem hiding this comment.
input won't be empty - it's either the default value passed by yargs, or the input passed by the user
src/dependency-check.js
Outdated
| let input = argv.input | ||
|
|
||
| if (argv.productionOnly) { | ||
| if (!hasPassedFileArgs(processArgs)) { |
There was a problem hiding this comment.
the defaults are only used below so input should be empty right ?
|
This is running against js-ipfs here: ipfs/js-ipfs#3395 |
|
This is broken on windows at the moment because of the issue noticed here. It's not due to this PR though, we just weren't testing this codepath on Windows before.. |
|
I've forked dependency-check to fix the windows breakage, PR here: dependency-check-team/dependency-check#127 |
|
I've created a temporary fork of dependency-check so we can move forward while dependency-check-team/dependency-check#127 is resolved. |
achingbrain
changed the title
Adds a convenience flag to only check for missing production deps.
Also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up.
Also, also adds
--ignoreoptions to the dep check so we can pass options to aegir and to the underlying dependency-check binary.Would have caught ipfs/js-ipfs#3393