feat: update ts config and new linter #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
requested review from
Gozala,
vasco-santos and
achingbrain
and removed request for
Gozala
Gozala
approved these changes
Dec 17, 2020
vasco-santos
approved these changes
Dec 17, 2020
achingbrain
approved these changes
Dec 17, 2020
- add "isolatedModules": true, - "importsNotUsedAsValues": "error", - "noImplicitAny": true, - add a must read section to the ts docs - self lint Some of these changes here and in the new linter config version try to encode/force best pratices found in the references added in the "must read" section in the ts docs. We should try to extract more rules from those articles into linter rules or ts config options. @Gozala
hugomrdias
force-pushed
the
feat/ts-rules
branch
from
a3bd075 to
e4637d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these changes here and in the new linter config version try to encode/force best pratices found in the references added in the "must read" section in the ts docs.
We should try to extract more rules from those articles into linter rules or ts config options. @Gozala
needs:
ipfs/eslint-config-ipfs#3