Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): add TAR, IPNS Record, DAG-* histograms and spans #155

Merged
merged 2 commits into from
Feb 8, 2023
Merged

feat(gateway): add TAR, IPNS Record, DAG-* histograms and spans #155

merged 2 commits into from
Feb 8, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 6, 2023 •
edited
Loading

@hacdias hacdias self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #155 (15b8f7c) into main (1a932f7) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   19.77%   19.63%   -0.14%     
==========================================
  Files         100      100              
  Lines       10968    11046      +78     
==========================================
  Hits         2169     2169              
- Misses       8512     8590      +78     
  Partials      287      287
Impacted Files Coverage Δ
examples/gateway/car/main.go 8.00% <0.00%> (-1.84%) ⬇️
examples/gateway/proxy/main.go 0.00% <0.00%> (ø)
examples/gateway/proxy/routing.go 9.52% <ø> (+0.11%) ⬆️
gateway/handler.go 5.14% <0.00%> (-0.18%) ⬇️
gateway/handler_block.go 0.00% <0.00%> (ø)
gateway/handler_car.go 0.00% <0.00%> (ø)
gateway/handler_codec.go 0.00% <0.00%> (ø)
gateway/handler_ipns_record.go 0.00% <0.00%> (ø)
gateway/handler_tar.go 0.00% <0.00%> (ø)
gateway/handler_unixfs.go 0.00% <0.00%> (ø)
... and 1 more

@hacdias hacdias marked this pull request as ready for review February 6, 2023 10:57
@hacdias hacdias requested a review from lidel as a code owner February 6, 2023 10:57
lidel
lidel requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias mind resolving conflicts + opening PR in kubo so we dont forget bubbling this up there?

lidel
lidel requested changes Feb 7, 2023
View reviewed changes
gateway/handler.go Outdated Show resolved Hide resolved
gateway/handler.go Outdated Show resolved Hide resolved
@hacdias hacdias changed the title feat(gateway): add missing metrics feat(gateway): add TAR, IPNS Record, DAG-* histograms and spans Feb 7, 2023
@hacdias hacdias force-pushed the issue/154 branch 2 times, most recently from e3243a7 to bd3e4a1 Compare February 7, 2023 09:56
@hacdias hacdias mentioned this pull request Feb 7, 2023
Merged
2 tasks
@hacdias hacdias requested a review from lidel February 7, 2023 10:25
lidel
lidel approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added deprecation notice about unixfs_get_latency_seconds.
Merging so we can use this in bifrost-gateway (will document and refine in follow-up PRs).

examples/gateway/car/main.go Outdated Show resolved Hide resolved
examples/gateway/car/main.go Outdated Show resolved Hide resolved
examples/gateway/proxy/main.go Outdated Show resolved Hide resolved
examples/gateway/proxy/main.go Outdated Show resolved Hide resolved
gateway/handler.go Outdated Show resolved Hide resolved
@lidel lidel merged commit 378aaf7 into main Feb 8, 2023
@lidel lidel deleted the issue/154 branch February 8, 2023 02:29
@hacdias hacdias mentioned this pull request Feb 13, 2023
Merged
@lidel lidel mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gateway: add missing metrics and traces
2 participants
@hacdias @lidel